Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: extend LISTEN_X #2208

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

ekoops
Copy link
Contributor

@ekoops ekoops commented Dec 18, 2024

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-gvisor

/area libscap

/area libsinsp

/area tests

Does this PR require a change in the driver versions?

/version driver-SCHEMA-version-minor

What this PR does / why we need it:

This PR is part of #2068.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link

github-actions bot commented Dec 18, 2024

Perf diff from master - unit tests

     2.86%     -0.79%  [.] sinsp_parser::process_event
     3.86%     +0.74%  [.] gzfile_read
     8.51%     -0.60%  [.] sinsp_evt::get_type
     1.16%     -0.50%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     3.52%     -0.34%  [.] sinsp_thread_manager::find_thread
     1.12%     +0.32%  [.] std::_Hashtable<unsigned long, std::pair<unsigned long const, std::shared_ptr<ppm_evt_hdr> >, std::allocator<std::pair<unsigned long const, std::shared_ptr<ppm_evt_hdr> > >, std::__detail::_Select1st, std::equal_to<unsigned long>, std::hash<unsigned long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     2.08%     +0.32%  [.] is_conversion_needed
     0.40%     +0.31%  [.] sinsp_parser::parse_open_openat_creat_exit
     0.39%     +0.27%  [.] scap_event_has_large_payload
    10.62%     +0.26%  [.] sinsp_parser::reset

Heap diff from master - unit tests

peak heap memory consumption: -1.95K
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: -116B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0680         +0.0680           144           154           144           154
BM_sinsp_split_median                                          +0.0605         +0.0605           145           154           145           154
BM_sinsp_split_stddev                                          -0.4679         -0.4670             3             1             3             1
BM_sinsp_split_cv                                              -0.5018         -0.5010             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0278         -0.0278            63            62            63            62
BM_sinsp_concatenate_paths_relative_path_median                -0.0275         -0.0275            63            62            63            61
BM_sinsp_concatenate_paths_relative_path_stddev                -0.1201         -0.1235             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.0949         -0.0985             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0463         +0.0463            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_median                   +0.0467         +0.0466            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.4928         -0.4929             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.5152         -0.5153             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0642         -0.0642            64            59            64            59
BM_sinsp_concatenate_paths_absolute_path_median                -0.0709         -0.0709            64            59            64            59
BM_sinsp_concatenate_paths_absolute_path_stddev                +8.8284         +8.8207             0             2             0             2
BM_sinsp_concatenate_paths_absolute_path_cv                    +9.5022         +9.4942             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0051         -0.0051           390           388           390           388
BM_sinsp_split_container_image_median                          -0.0048         -0.0048           390           388           390           388
BM_sinsp_split_container_image_stddev                          -0.3756         -0.3776             3             2             3             2
BM_sinsp_split_container_image_cv                              -0.3724         -0.3744             0             0             0             0

@FedeDP
Copy link
Contributor

FedeDP commented Dec 19, 2024

/milestone 0.20.0

@poiana poiana added this to the 0.20.0 milestone Dec 19, 2024
@ekoops ekoops force-pushed the ekoops/convert-listen branch from 29957b2 to 5f2ab0d Compare December 19, 2024 09:45
Andreagit97
Andreagit97 previously approved these changes Dec 19, 2024
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Amazing work!

@poiana
Copy link
Contributor

poiana commented Dec 19, 2024

LGTM label has been added.

Git tree hash: a21380b83a3fd7c57ce328eb04f9ca88a553d0ac

@Andreagit97
Copy link
Member

/hold
I would like to solve the SCEMA_VERSION versioning before going on cc @leogr

FedeDP
FedeDP previously approved these changes Dec 19, 2024
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@Andreagit97
Copy link
Member

It turns out that the legacy ebpf probe requires a major bump of the SCHEMA_VERSION every time we:

  • add a new filler-code (like in this PR)
  • we add some parameters to an existing filler

So to avoid a major bump at every new PR of the sys_enter/sys_exit workstream we will slightly change the compatibility rules for the legacy ebpf in the scap ebpf engine... For now we can just bump the minor in this PR, we will change the compatibility behavior in another PR

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekoops can you please adapt the versions?

driver/SCHEMA_VERSION Outdated Show resolved Hide resolved
userspace/libscap/scap.h Outdated Show resolved Hide resolved
Signed-off-by: Leonardo Di Giovanna <[email protected]>
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Dec 19, 2024
@poiana
Copy link
Contributor

poiana commented Dec 19, 2024

LGTM label has been added.

Git tree hash: 18c9d11217a1174bb7e4123dba72f53936f42a02

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, ekoops, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit aad67bc into falcosecurity:master Dec 19, 2024
55 of 57 checks passed
@ekoops ekoops deleted the ekoops/convert-listen branch December 19, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants