Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): run apt-get update in coverage ci. #2209

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix(ci): run apt-get update in coverage ci. #2209

merged 1 commit into from
Dec 19, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Dec 19, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP FedeDP changed the title wip: fix(ci): run apt-get update in coverage ci. fix(ci): run apt-get update in coverage ci. Dec 19, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 19, 2024

/milestone 0.20.0

@poiana poiana added this to the 0.20.0 milestone Dec 19, 2024
Copy link

Perf diff from master - unit tests

    10.61%     +0.49%  [.] sinsp_parser::reset
    11.63%     +0.44%  [.] sinsp::next
     8.50%     +0.34%  [.] sinsp_evt::get_type
     0.49%     +0.31%  [.] sinsp_fdtable::find
     3.85%     +0.30%  [.] gzfile_read
     1.35%     -0.27%  [.] sinsp_evt::get_ts
     0.73%     +0.24%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     5.79%     +0.22%  [.] next_event_from_file
     1.18%     -0.22%  [.] sinsp_parser::event_cleanup
     0.69%     -0.22%  [.] sinsp_evt::get_direction

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0388         +0.0388           144           150           144           150
BM_sinsp_split_median                                          +0.0305         +0.0306           145           149           145           149
BM_sinsp_split_stddev                                          -0.6356         -0.6348             3             1             3             1
BM_sinsp_split_cv                                              -0.6492         -0.6484             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.1077         -0.1077            63            56            63            56
BM_sinsp_concatenate_paths_relative_path_median                -0.1064         -0.1064            63            57            63            57
BM_sinsp_concatenate_paths_relative_path_stddev                -0.1762         -0.1753             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.0768         -0.0758             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0349         +0.0349            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_median                   +0.0334         +0.0334            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.2652         -0.2651             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.2900         -0.2899             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.1202         -0.1202            64            56            64            56
BM_sinsp_concatenate_paths_absolute_path_median                -0.1206         -0.1206            64            56            64            56
BM_sinsp_concatenate_paths_absolute_path_stddev                +0.5940         +0.5931             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    +0.8117         +0.8108             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0020         -0.0020           390           389           390           389
BM_sinsp_split_container_image_median                          -0.0032         -0.0032           390           389           390           389
BM_sinsp_split_container_image_stddev                          +0.1887         +0.1883             3             3             3             3
BM_sinsp_split_container_image_cv                              +0.1911         +0.1907             0             0             0             0

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.40%. Comparing base (9ee57c8) to head (e7e0925).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2209      +/-   ##
==========================================
+ Coverage   75.38%   75.40%   +0.01%     
==========================================
  Files         264      264              
  Lines       34014    34016       +2     
  Branches     5805     5803       -2     
==========================================
+ Hits        25642    25649       +7     
+ Misses       8372     8367       -5     
Flag Coverage Δ
libsinsp 75.40% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poiana poiana merged commit 69cfe47 into master Dec 19, 2024
47 of 49 checks passed
@poiana poiana deleted the fix/coverage_ci branch December 19, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants