Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: make ACCEPT_{E,X} and ACCEPT_5_E converter-managed #2211

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

ekoops
Copy link
Contributor

@ekoops ekoops commented Dec 19, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR is part of #2068.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link

Please double check driver/SCHEMA_VERSION file. See versioning.

/hold

@ekoops ekoops changed the title new: make ACCEPT_{E,X} and ACCEPT_5_{E,X} converter-managed new: make ACCEPT_{E,X} and ACCEPT_5_{E,X} converter-managed Dec 19, 2024
Copy link

github-actions bot commented Dec 19, 2024

Perf diff from master - unit tests

    10.69%     +0.43%  [.] sinsp_parser::reset
     0.75%     +0.40%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::find
     6.08%     -0.30%  [.] next_event_from_file
    11.63%     +0.29%  [.] sinsp::next
     0.84%     -0.25%  [.] sinsp_evt::get_direction
     1.52%     +0.23%  [.] sinsp_evt_filter::sinsp_evt_filter
     4.27%     -0.21%  [.] gzfile_read
     1.98%     -0.21%  [.] scap_event_decode_params
     0.92%     -0.20%  [.] libsinsp::events::is_unknown_event
     1.02%     +0.18%  [.] sinsp_parser::event_cleanup

Heap diff from master - unit tests

peak heap memory consumption: -178B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: -178B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0210         +0.0211           146           149           146           149
BM_sinsp_split_median                                          +0.0218         +0.0219           146           149           146           149
BM_sinsp_split_stddev                                          +0.8031         +0.8032             1             2             1             2
BM_sinsp_split_cv                                              +0.7661         +0.7660             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.1036         +0.1037            56            61            56            61
BM_sinsp_concatenate_paths_relative_path_median                +0.1049         +0.1050            56            61            56            61
BM_sinsp_concatenate_paths_relative_path_stddev                -0.3864         -0.3872             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.4440         -0.4448             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0147         +0.0148            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_median                   +0.0125         +0.0126            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_stddev                   +0.1678         +0.1672             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +0.1509         +0.1502             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.1809         +0.1810            55            65            55            65
BM_sinsp_concatenate_paths_absolute_path_median                +0.1821         +0.1822            55            65            55            65
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.2911         -0.2902             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.3997         -0.3990             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0169         +0.0170           385           392           385           392
BM_sinsp_split_container_image_median                          +0.0159         +0.0160           386           392           386           392
BM_sinsp_split_container_image_stddev                          +0.5610         +0.5612             2             3             2             3
BM_sinsp_split_container_image_cv                              +0.5351         +0.5351             0             0             0             0

@ekoops ekoops force-pushed the ekoops/convert-accept branch from 855d87d to b7131e0 Compare December 19, 2024 15:21
@ekoops ekoops changed the title new: make ACCEPT_{E,X} and ACCEPT_5_{E,X} converter-managed new: make ACCEPT_{E,X} and ACCEPT_5_E converter-managed Dec 19, 2024
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 19, 2024

LGTM label has been added.

Git tree hash: 7e269c21264833aa5421f385a31ac829da769d39

@Andreagit97
Copy link
Member

Please double check driver/SCHEMA_VERSION file. See versioning.

/hold

/unhold

This is a false positive

@Andreagit97 Andreagit97 added this to the 0.20.0 milestone Dec 19, 2024
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, ekoops, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 5b95bc8 into falcosecurity:master Dec 20, 2024
54 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants