-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: make ACCEPT_{E,X}
and ACCEPT_5_E
converter-managed
#2211
Conversation
Please double check driver/SCHEMA_VERSION file. See versioning. /hold |
ACCEPT_{E,X}
and ACCEPT_5_{E,X}
converter-managed
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
Signed-off-by: Leonardo Di Giovanna <[email protected]>
855d87d
to
b7131e0
Compare
ACCEPT_{E,X}
and ACCEPT_5_{E,X}
converter-managedACCEPT_{E,X}
and ACCEPT_5_E
converter-managed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 7e269c21264833aa5421f385a31ac829da769d39
|
/unhold This is a false positive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, ekoops, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area libscap-engine-savefile
/area libscap
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This PR is part of #2068.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: