update(ci): bump zig to official 0.14.0 and drop caching #2300

FedeDP · 2025-03-05T07:59:48Z

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Zig 0.14.0 has been released, we don't need to cache the version ourselves.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

poiana · 2025-03-05T07:59:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

FedeDP · 2025-03-05T08:00:03Z

/hold

FedeDP · 2025-03-05T08:00:12Z

/milestone 0.21.0

github-actions · 2025-03-05T08:04:44Z

Perf diff from master - unit tests

     5.62%     -0.31%  [.] sinsp_evt::get_type
     0.57%     +0.25%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::find
     6.46%     +0.22%  [.] sinsp::next
     0.40%     +0.16%  [.] std::_Hashtable<conversion_key, std::pair<conversion_key const, conversion_info>, std::allocator<std::pair<conversion_key const, conversion_info> >, std::__detail::_Select1st, std::equal_to<conversion_key>, std::hash<conversion_key>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::_M_find_before_node
     0.92%     +0.16%  [.] user_group_updater::~user_group_updater
     1.34%     +0.16%  [.] next
     0.60%     +0.15%  [.] libsinsp::events::is_unknown_event
     0.28%     +0.13%  [.] sinsp_fdtable::find
     9.21%     +0.12%  [.] sinsp_thread_manager::create_thread_dependencies
     5.96%     -0.12%  [.] sinsp_parser::reset

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0532         -0.0532           151           143           151           143
BM_sinsp_split_median                                          -0.0564         -0.0564           152           143           152           143
BM_sinsp_split_stddev                                          -0.3945         -0.3941             2             1             2             1
BM_sinsp_split_cv                                              -0.3605         -0.3600             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0884         -0.0884            60            54            60            54
BM_sinsp_concatenate_paths_relative_path_median                -0.0977         -0.0977            60            54            60            54
BM_sinsp_concatenate_paths_relative_path_stddev                -0.6289         -0.6288             2             1             2             1
BM_sinsp_concatenate_paths_relative_path_cv                    -0.5929         -0.5928             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0160         -0.0160            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_median                   -0.0175         -0.0175            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   +0.1705         +0.1707             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +0.1895         +0.1898             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.1100         -0.1100            59            52            59            52
BM_sinsp_concatenate_paths_absolute_path_median                -0.1126         -0.1126            59            52            59            52
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.4897         -0.4898             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.4267         -0.4268             0             0             0             0

codecov · 2025-03-05T08:07:48Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.17%. Comparing base (9dc846f) to head (626d030).
Report is 4 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2300   +/-   ##
=======================================
  Coverage   77.17%   77.17%           
=======================================
  Files         224      224           
  Lines       30133    30133           
  Branches     4600     4605    +5     
=======================================
  Hits        23256    23256           
  Misses       6877     6877

Flag	Coverage Δ
libsinsp	`77.17% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

FedeDP · 2025-03-10T10:38:14Z

Testing locally, the CI passes only for debug builds. Investigating.
Seems like ziglang/zig#23052 could be the culprit.

FedeDP · 2025-03-10T11:48:58Z

Opened a tracking issue: ziglang/zig#23185 🙏 i found a workaround but i'll wait for upstream feedback before proposing it.

FedeDP · 2025-03-10T12:18:03Z

I found out the issue: we were building zlib without -O3 thus letting zig enable ubsan for us even for release builds.
Gonna fix it soon.

Signed-off-by: Federico Di Pierro <[email protected]>

FedeDP · 2025-03-10T13:13:44Z

Will unhold once falcosecurity/falco#3508 CI passes fine.

FedeDP · 2025-03-10T13:14:07Z

.github/actions/install-zig/action.yml

@@ -8,23 +8,11 @@ runs:
      shell: bash
      id: store
      env:
-        ZIG_VERSION: '0.14.0-dev.3188+34644511b'
+        ZIG_VERSION: '0.14.0'


Bump zig version and drop caching.

FedeDP · 2025-03-10T13:14:32Z

cmake/modules/protobuf.cmake

@@ -72,8 +72,8 @@ else()
 			URL_HASH "SHA256=e51cc8fc496f893e2a48beb417730ab6cbcb251142ad8b2cd1951faa5c76fe3d"
 			# TODO what if using system zlib?
 			CONFIGURE_COMMAND
-				CPPFLAGS=-I${ZLIB_INCLUDE} LDFLAGS=-L${ZLIB_SRC} ./configure
-				CXXFLAGS=${PROTOBUF_CXXFLAGS} --with-zlib ${PROTOBUF_CONFIGURE_FLAGS}
+				./configure CXXFLAGS=${PROTOBUF_CXXFLAGS} --with-zlib-include=${ZLIB_INCLUDE}


Use the protobuf configure way of passing CPPFLAGS and LDFLAGS; this is basically the same we did before.

FedeDP · 2025-03-10T13:14:51Z

cmake/modules/re2.cmake

@@ -55,6 +55,7 @@ else()
 						   -DRE2_BUILD_TESTING=OFF
 						   -DBUILD_SHARED_LIBS=${BUILD_SHARED_LIBS}
 						   -DCMAKE_INSTALL_PREFIX=${RE2_SRC}
+						   -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}


Build re2 with the same build type of the main project.

FedeDP · 2025-03-10T13:15:07Z

cmake/modules/zlib.cmake

@@ -45,9 +45,13 @@ else()
 		"${ZLIB_INCLUDE}/zutil.h"
 	)
 	if(NOT TARGET zlib)
-		set(ZLIB_CFLAGS)
+		if(CMAKE_BUILD_TYPE STREQUAL "Release")
+			set(ZLIB_CFLAGS "-O3")


Build zlib with the same optimization of the main project.

Signed-off-by: Federico Di Pierro <[email protected]>

…uilds. Signed-off-by: Federico Di Pierro <[email protected]>

FedeDP · 2025-03-11T08:17:37Z

/unhold

poiana added dco-signoff: no do-not-merge/release-note-label-needed labels Mar 5, 2025

poiana requested review from hbrueckner and LucaGuerra March 5, 2025 07:59

poiana added the approved label Mar 5, 2025

poiana added size/S do-not-merge/hold labels Mar 5, 2025

poiana added this to the 0.21.0 milestone Mar 5, 2025

poiana added release-note-none and removed do-not-merge/release-note-label-needed labels Mar 10, 2025

FedeDP force-pushed the FedeDP-patch-1 branch 2 times, most recently from 0cfc1e4 to cebbd47 Compare March 10, 2025 09:50

FedeDP added 3 commits March 10, 2025 13:47

update(ci): bump zig to official 0.14.0 and drop caching

6bbddc0

Signed-off-by: Federico Di Pierro <[email protected]>

chore(cmake): enforce zlib-lib and zlib-include in protobuf.

5b19338

Signed-off-by: Federico Di Pierro <[email protected]>

fix(cmake): properly forward -O3 optimization to zlib in release mode.

dcb1266

Signed-off-by: Federico Di Pierro <[email protected]>

FedeDP force-pushed the FedeDP-patch-1 branch from cebbd47 to dcb1266 Compare March 10, 2025 12:47

poiana added dco-signoff: yes and removed dco-signoff: no labels Mar 10, 2025

FedeDP added area/build area/CI kind/cleanup labels Mar 10, 2025

FedeDP added a commit to falcosecurity/falco that referenced this pull request Mar 10, 2025

wip: test falcosecurity/libs#2300

780eac8

Signed-off-by: Federico Di Pierro <[email protected]>

FedeDP mentioned this pull request Mar 10, 2025

update(cmake): update libs and driver to latest master falcosecurity/falco#3508

Open

fix(cmake): honor CMAKE_BUILD_TYPE for re2.

eafdfe5

Signed-off-by: Federico Di Pierro <[email protected]>

poiana added size/M and removed size/S labels Mar 10, 2025

FedeDP added a commit to falcosecurity/falco that referenced this pull request Mar 10, 2025

wip: test falcosecurity/libs#2300

b4d6db7

Signed-off-by: Federico Di Pierro <[email protected]>

FedeDP commented Mar 10, 2025

View reviewed changes

FedeDP added 2 commits March 10, 2025 14:19

chore(cmake): use -O3 for protobuf.

02b9f3a

Signed-off-by: Federico Di Pierro <[email protected]>

chore(cmake): match both release and relwithdebinfo (used by Falco) b…

626d030

…uilds. Signed-off-by: Federico Di Pierro <[email protected]>

poiana removed the do-not-merge/hold label Mar 11, 2025

leogr approved these changes Mar 11, 2025

View reviewed changes

poiana assigned leogr Mar 11, 2025

poiana added the lgtm label Mar 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update(ci): bump zig to official 0.14.0 and drop caching #2300

update(ci): bump zig to official 0.14.0 and drop caching #2300

FedeDP commented Mar 5, 2025 •

edited

Loading

poiana commented Mar 5, 2025

FedeDP commented Mar 5, 2025

FedeDP commented Mar 5, 2025

github-actions bot commented Mar 5, 2025 •

edited

Loading

codecov bot commented Mar 5, 2025 •

edited

Loading

FedeDP commented Mar 10, 2025

FedeDP commented Mar 10, 2025

FedeDP commented Mar 10, 2025

FedeDP commented Mar 10, 2025

FedeDP Mar 10, 2025

FedeDP Mar 10, 2025

FedeDP Mar 10, 2025

FedeDP Mar 10, 2025

FedeDP commented Mar 11, 2025

update(ci): bump zig to official 0.14.0 and drop caching #2300

Are you sure you want to change the base?

update(ci): bump zig to official 0.14.0 and drop caching #2300

Conversation

FedeDP commented Mar 5, 2025 • edited Loading

poiana commented Mar 5, 2025

FedeDP commented Mar 5, 2025

FedeDP commented Mar 5, 2025

github-actions bot commented Mar 5, 2025 • edited Loading

Perf diff from master - unit tests

Heap diff from master - unit tests

Heap diff from master - scap file

Benchmarks diff from master

codecov bot commented Mar 5, 2025 • edited Loading

Codecov Report

FedeDP commented Mar 10, 2025

FedeDP commented Mar 10, 2025

FedeDP commented Mar 10, 2025

FedeDP commented Mar 10, 2025

FedeDP Mar 10, 2025

Choose a reason for hiding this comment

FedeDP Mar 10, 2025

Choose a reason for hiding this comment

FedeDP Mar 10, 2025

Choose a reason for hiding this comment

FedeDP Mar 10, 2025

Choose a reason for hiding this comment

FedeDP commented Mar 11, 2025

FedeDP commented Mar 5, 2025 •

edited

Loading

github-actions bot commented Mar 5, 2025 •

edited

Loading

codecov bot commented Mar 5, 2025 •

edited

Loading