new(driver): unify support for io_uring syscall family between drivers
#844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/feature
|
Wow great job Andrea! Gonna give a look at this asap! |
FedeDP
reviewed
Jan 27, 2023
Yes, collected data don't change if the syscall is successful or fails, so testing the failure case without adding other entropy in the testing framework seems the right way to go :) |
hbrueckner
reviewed
Jan 30, 2023
driver/modern_bpf/programs/tail_called/events/syscall_dispatched_events/io_uring_enter.bpf.c
Show resolved
Hide resolved
hbrueckner
reviewed
Jan 30, 2023
driver/modern_bpf/programs/tail_called/events/syscall_dispatched_events/io_uring_setup.bpf.c
Outdated
Show resolved
Hide resolved
hbrueckner
reviewed
Jan 30, 2023
test/drivers/test_suites/syscall_exit_suite/io_uring_setup_x.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrea Terzolo <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]> Co-authored-by: Federico Di Pierro <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]> Co-authored-by: Hendrik Brueckner <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]> Co-authored-by: Hendrik Brueckner <[email protected]>
Andreagit97
force-pushed
the
io_uring_syscalls
branch
from
c13a4c5 to
502ecb7
Compare
|
Rebased and added 3 commits to address review comments :) |
|
LGTM label has been added. Git tree hash: 128a1a6ef32bd1150154aacbf8d3e99e7b4c0d73
|
hbrueckner
approved these changes
Jan 31, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, hbrueckner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area driver-kmod
/area driver-bpf
/area driver-modern-bpf
/area libpman
/area tests
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
On one side this PR supports 3 missing syscalls in the modern bpf probe #723:
io_uring_enterio_uring_registerio_uring_setupOn the other side it unifies the behavior of this syscall between our 3 drivers:
struct io_uring_paramsis invalidWhich issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: