Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(plugins/k8saudit): add subject name fields #548

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

What this PR does / why we need it:

Sometimes people need to match/display k8s audit events against the actual user that is in the subject section. These fields will split them between regular users, groups and service accounts.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Copy link

github-actions bot commented Dec 9, 2024

Rules files suggestions

rules

Comparing 52452d06f6a2143d0db6e5ef71cb87a01ccb4b10 with latest tag plugins/k8saudit/v0.11.0

No changes detected

@LucaGuerra LucaGuerra changed the title wip: new(plugins/k8saudit): add subject name fields new(plugins/k8saudit): add subject name fields Dec 17, 2024
@Issif
Copy link
Member

Issif commented Dec 17, 2024

/lgtm

@poiana
Copy link
Contributor

poiana commented Dec 17, 2024

LGTM label has been added.

Git tree hash: cf301f5de3678a8e7efd24903b35a548faaa8517

@poiana
Copy link
Contributor

poiana commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr
Copy link
Member

leogr commented Dec 17, 2024

SMGT to me, I will give it a second look before the final approve.

@LucaGuerra @Issif
Note for ourselves: we will need to update dependent plugins as well (i.e., aks, -eks, -like...)

@leogr
Copy link
Member

leogr commented Dec 17, 2024

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants