Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vote: Add k8saudit-ovh plugin #554

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

scraly
Copy link

@scraly scraly commented Dec 19, 2024

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area plugins

What this PR does / why we need it:

Add "k8saudit-ovh" plugin as an alternative to "k8saudit".

URL of the plugin: https://github.com/scraly/k8saudit-ovh/

Signed-off-by: Aurelie Vache <[email protected]>
@poiana
Copy link
Contributor

poiana commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: scraly
Once this PR has been reviewed and has the lgtm label, please assign lucaguerra for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Dec 19, 2024

Welcome @scraly! It looks like this is your first PR to falcosecurity/plugins 🎉

Copy link

Rules files suggestions

rules

Comparing 174b5fb03a5bee0ce672641a3393c63be5fe3056 with latest tag plugins/k8saudit/v0.11.0

Patch changes:

  • Version dependency alternative to plugin k8saudit-ovh has added
  • Version dependency alternative to plugin k8saudit-ovh has added
  • Version dependency alternative to plugin k8saudit-ovh has added

Signed-off-by: Aurelie Vache <[email protected]>
@scraly
Copy link
Author

scraly commented Dec 19, 2024

I changed the Plugin ID 21 to 22 in registry.yaml file because it seems that in another PR the AKS Audit Log plugin will be the 21 ;)

@poiana
Copy link
Contributor

poiana commented Dec 19, 2024

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the falcosecurity org. You can then trigger verification by writing /verify-owners in a comment.

  • scraly
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

@leogr
Copy link
Member

leogr commented Dec 19, 2024

/assign

@leogr
Copy link
Member

leogr commented Dec 19, 2024

Hey @scraly

Thank you so much for this PR and contribution. I'm thrilled you wanted to donate this and propose to yourself (within tin @Issif) as a maintainer 🙏

Since this is a maintainer addition, as per our governance, we will go with a quick majority vote among @falcosecurity/plugins-maintainers. This process will take no more than one week.

Meanwhile, we will start reviewing the code. You may expect some delay, considering the upcoming holidays, but I want to let you know that we are on it :)

Thanks

@leogr leogr changed the title Add k8saudit-ovh plugin vote: Add k8saudit-ovh plugin Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants