-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove exe_flags=%evt.arg.flags
output from each non spawned_process rule
#217
Conversation
Rules files suggestionsfalco-incubating_rules.yamlComparing Minor changes:
Patch changes:
falco_rules.yamlComparing Minor changes:
Patch changes:
falco-sandbox_rules.yamlComparing Patch changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to keep the exe_flags=%evt.arg.flags
in all rules with spawned_process
and remove all the other usages instead of renaming them. exe_flags
has a lot of value because it reports exe_writable
/exe_upper_layer
flag, in all other cases i don't see so much value, WDYT?
Indifferent at the end of the day. Let's wait to hear from more folks and go with what everyone prefers. |
I agree with
+1 from me |
… rule Signed-off-by: Melissa Kilby <[email protected]>
f64cf5c
to
8e38ff9
Compare
exe_flags=%evt.arg.flags
output from each non spawned_process rule
Roger that plz help me double-checking if it is all correct. Thanks! |
Rules files suggestionsfalco-incubating_rules.yamlComparing Minor changes:
Patch changes:
falco_rules.yamlComparing Minor changes:
Patch changes:
falco-sandbox_rules.yamlComparing Patch changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thank you!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, incertum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 502f5068f74538e8dc2bf16c29ba17c0f363dee6
|
What type of PR is this?
Any specific area of the project related to this PR?
/area rules
Proposed rule maturity level
/area maturity-stable
/area maturity-incubating
/area maturity-sandbox
What this PR does / why we need it:
chore: rename exe_flags= to flags= in output fields
Which issue(s) this PR fixes:
#176 (comment)
Fixes #
Special notes for your reviewer: