Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove exe_flags=%evt.arg.flags output from each non spawned_process rule #217

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

incertum
Copy link
Contributor

@incertum incertum commented Jan 8, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

Proposed rule maturity level

Uncomment one (or more) /area <> lines (only for PRs that add or modify rules):

/area maturity-stable

/area maturity-incubating

/area maturity-sandbox

/area maturity-deprecated

What this PR does / why we need it:

chore: rename exe_flags= to flags= in output fields

Which issue(s) this PR fixes:

#176 (comment)

Fixes #

Special notes for your reviewer:

@poiana poiana added area/rules dco-signoff: yes area/maturity-stable See the Rules Maturity Framework area/maturity-incubating See the Rules Maturity Framework area/maturity-sandbox See the Rules Maturity Framework labels Jan 8, 2024
@poiana poiana requested review from darryk10 and leodido January 8, 2024 22:13
Copy link

github-actions bot commented Jan 8, 2024

Rules files suggestions

falco-incubating_rules.yaml

Comparing 24ed7b81e8394313552d2ce14ca84f4dc73aea8d with latest tag falco-incubating-rules-2.0.0

Minor changes:

  • Rule Potential Local Privilege Escalation via Environment Variables Misuse has been added
  • Rule Adding ssh keys to authorized_keys has been added
  • Macro glibc_tunables_env has been added

Patch changes:

  • Rule Change thread namespace changed its output fields
  • Rule Launch Privileged Container changed its output fields
  • Rule Launch Excessively Capable Container changed its output fields
  • Rule System procs network activity changed its output fields
  • Rule Unexpected UDP Traffic changed its output fields
  • Rule Non sudo setuid changed its output fields
  • Rule Contact EC2 Instance Metadata Service From Container changed its output fields
  • Rule Contact cloud metadata service from container changed its output fields
  • Rule Delete or rename shell history changed its output fields
  • Rule Set Setuid or Setgid bit changed its output fields
  • Rule Network Connection outside Local Subnet changed its output fields

falco_rules.yaml

Comparing 24ed7b81e8394313552d2ce14ca84f4dc73aea8d with latest tag falco-rules-2.0.0

Minor changes:

  • Macro containerd_activities has been added

Patch changes:

  • Rule Contact K8S API Server From Container changed its output fields
  • Rule Create Symlink Over Sensitive Files changed its output fields
  • Rule Create Hardlink Over Sensitive Files changed its output fields
  • Rule Packet socket created in container changed its output fields
  • Rule Redirect STDOUT/STDIN to Network Connection in Container changed its output fields
  • Rule Linux Kernel Module Injection Detected changed its output fields
  • Rule PTRACE attached to process changed its output fields
  • Rule PTRACE anti-debug attempt changed its output fields
  • Rule Disallowed SSH Connection Non Standard Port changed its output fields

falco-sandbox_rules.yaml

Comparing 24ed7b81e8394313552d2ce14ca84f4dc73aea8d with latest tag falco-sandbox-rules-2.0.0

Patch changes:

  • Rule Unexpected inbound connection source changed its output fields
  • Rule Modify binary dirs changed its output fields
  • Rule Mkdir binary dirs changed its output fields
  • Rule Launch Sensitive Mount Container changed its output fields
  • Rule Launch Disallowed Container changed its output fields
  • Rule Interpreted procs inbound network activity changed its output fields
  • Rule Interpreted procs outbound network activity changed its output fields
  • Rule Unexpected K8s NodePort Connection changed its output fields
  • Rule Create Hidden Files or Directories changed its output fields
  • Rule Detect outbound connections to common miner pool ports changed its output fields
  • Rule Container Drift Detected (chmod) changed its output fields
  • Rule Unprivileged Delegation of Page Faults Handling to a Userspace Process changed its output fields
  • Rule Java Process Class File Download changed its output fields
  • Rule BPF Program Not Profiled changed its output fields

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to keep the exe_flags=%evt.arg.flags in all rules with spawned_process and remove all the other usages instead of renaming them. exe_flags has a lot of value because it reports exe_writable/exe_upper_layer flag, in all other cases i don't see so much value, WDYT?

rules/falco-incubating_rules.yaml Show resolved Hide resolved
@incertum
Copy link
Contributor Author

incertum commented Jan 9, 2024

I would prefer to keep the exe_flags=%evt.arg.flags in all rules with spawned_process and remove all the other usages instead of renaming them. exe_flags has a lot of value because it reports exe_writable/exe_upper_layer flag, in all other cases i don't see so much value, WDYT?

Indifferent at the end of the day. Let's wait to hear from more folks and go with what everyone prefers.
Only asking for a final decision so that we update the style guide one more time now and hopefully afterwards things can stabilize.

@loresuso
Copy link
Member

I agree with

I would prefer to keep the exe_flags=%evt.arg.flags in all rules with spawned_process and remove all the other usages instead of renaming them

+1 from me

@incertum incertum force-pushed the rename-flags-output branch from f64cf5c to 8e38ff9 Compare January 11, 2024 06:27
@poiana poiana added size/M and removed size/L labels Jan 11, 2024
@incertum incertum changed the title chore: rename exe_flags= to flags= in output fields chore: remove exe_flags=%evt.arg.flags output from each non spawned_process rule Jan 11, 2024
@incertum
Copy link
Contributor Author

Roger that plz help me double-checking if it is all correct. Thanks!

Copy link

Rules files suggestions

falco-incubating_rules.yaml

Comparing 8f52e05fb16d5c735d0f04d9361d3f7b2319bc88 with latest tag falco-incubating-rules-2.0.0

Minor changes:

  • Rule Potential Local Privilege Escalation via Environment Variables Misuse has been added
  • Rule Adding ssh keys to authorized_keys has been added
  • Macro glibc_tunables_env has been added

Patch changes:

  • Rule Modify Shell Configuration File changed its output fields
  • Rule Schedule Cron Jobs changed its output fields
  • Rule Read ssh information changed its output fields
  • Rule Change thread namespace changed its output fields
  • Rule Change namespace privileges via unshare changed its output fields
  • Rule Launch Privileged Container changed its output fields
  • Rule Launch Excessively Capable Container changed its output fields
  • Rule System procs network activity changed its output fields
  • Rule Unexpected UDP Traffic changed its output fields
  • Rule Non sudo setuid changed its output fields
  • Rule Create files below dev changed its output fields
  • Rule Contact EC2 Instance Metadata Service From Container changed its output fields
  • Rule Contact cloud metadata service from container changed its output fields
  • Rule Delete or rename shell history changed its output fields
  • Rule Set Setuid or Setgid bit changed its output fields
  • Rule Network Connection outside Local Subnet changed its output fields
  • Rule Read environment variable from /proc files changed its output fields
  • Rule Exfiltrating Artifacts via Kubernetes Control Plane changed its output fields

falco_rules.yaml

Comparing 8f52e05fb16d5c735d0f04d9361d3f7b2319bc88 with latest tag falco-rules-2.0.0

Minor changes:

  • Macro containerd_activities has been added

Patch changes:

  • Rule Directory traversal monitored file read changed its output fields
  • Rule Read sensitive file trusted after startup changed its output fields
  • Rule Read sensitive file untrusted changed its output fields
  • Rule Contact K8S API Server From Container changed its output fields
  • Rule Clear Log Activities changed its output fields
  • Rule Create Symlink Over Sensitive Files changed its output fields
  • Rule Create Hardlink Over Sensitive Files changed its output fields
  • Rule Packet socket created in container changed its output fields
  • Rule Redirect STDOUT/STDIN to Network Connection in Container changed its output fields
  • Rule Linux Kernel Module Injection Detected changed its output fields
  • Rule Detect release_agent File Container Escapes changed its output fields
  • Rule PTRACE attached to process changed its output fields
  • Rule PTRACE anti-debug attempt changed its output fields
  • Rule Disallowed SSH Connection Non Standard Port changed its output fields

falco-sandbox_rules.yaml

Comparing 8f52e05fb16d5c735d0f04d9361d3f7b2319bc88 with latest tag falco-sandbox-rules-2.0.0

Patch changes:

  • Rule Unexpected inbound connection source changed its output fields
  • Rule Read Shell Configuration File changed its output fields
  • Rule Update Package Repository changed its output fields
  • Rule Write below binary dir changed its output fields
  • Rule Write below monitored dir changed its output fields
  • Rule Write below etc changed its output fields
  • Rule Write below root changed its output fields
  • Rule Write below rpm database changed its output fields
  • Rule Modify binary dirs changed its output fields
  • Rule Mkdir binary dirs changed its output fields
  • Rule Launch Sensitive Mount Container changed its output fields
  • Rule Launch Disallowed Container changed its output fields
  • Rule Interpreted procs inbound network activity changed its output fields
  • Rule Interpreted procs outbound network activity changed its output fields
  • Rule Unexpected K8s NodePort Connection changed its output fields
  • Rule Create Hidden Files or Directories changed its output fields
  • Rule Detect outbound connections to common miner pool ports changed its output fields
  • Rule Container Drift Detected (chmod) changed its output fields
  • Rule Container Drift Detected (open+create) changed its output fields
  • Rule Unprivileged Delegation of Page Faults Handling to a Userspace Process changed its output fields
  • Rule Java Process Class File Download changed its output fields
  • Rule Modify Container Entrypoint changed its output fields
  • Rule BPF Program Not Profiled changed its output fields

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Thank you!

@poiana
Copy link

poiana commented Jan 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, incertum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Jan 11, 2024

LGTM label has been added.

Git tree hash: 502f5068f74538e8dc2bf16c29ba17c0f363dee6

@poiana poiana merged commit 2ac430b into falcosecurity:main Jan 11, 2024
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/maturity-incubating See the Rules Maturity Framework area/maturity-sandbox See the Rules Maturity Framework area/maturity-stable See the Rules Maturity Framework area/rules dco-signoff: yes lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants