rules: add support for k3s to containerd_activities macro #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/feature
|
Welcome @kyrofa! It looks like this is your first PR to falcosecurity/rules 🎉 |
K3s is a stripped down version of Kubernetes that bundles dependencies within it, including containerd. It puts containerd files (sockets, tmpmounts, snapshotter overlayfs, etc.) in namespaced, non-standard locations in an attempt to not interfere with a system-wide containerd installation. As a result, the "Clear Log Activities" rule triggers warnings for the bundled containerd. Fix that by including K3s' non-standard paths in the containerd_activities macro. Signed-off-by: Kyle Fazzari <[email protected]>
kyrofa
force-pushed
the
feature/containerd_activities_k3s
branch
from
d3e4882 to
ba1f283
Compare
darryk10
approved these changes
Mar 2, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: darryk10, kyrofa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: e1a86f63028b7c1035854914233f88af44613533
|
|
Thanks folks! How do I actually track this to a release so I can know when I can drop my customized rules? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area rules
Proposed rule maturity level
/area maturity-stable
K3s is a stripped down version of Kubernetes that bundles dependencies within it, including containerd. It puts containerd files (sockets, tmpmounts, snapshotter overlayfs, etc.) in namespaced, non-standard locations in an attempt to not interfere with a system-wide containerd installation. As a result, the "Clear Log Activities" rule triggers warnings for the bundled containerd. Fix that by including K3s' non-standard paths in the containerd_activities macro.