Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add release charts workflow #1140

Merged
merged 13 commits into from
Jan 12, 2025
Merged

Conversation

M0NsTeRRR
Copy link
Contributor

@M0NsTeRRR M0NsTeRRR commented Dec 8, 2024

Description

Add a Helm chart release workflow. All charts will be signed using keyless signing (with Cosign) and published to ghcr.io with the image name <chart name>-chart to avoid conflicts with the Jellyseerr Docker image.
The ArtifactHub configuration file will also be signed and pushed to the registry.

You can see an example in my fork :

TO DO

ArtifactHub is a CNCF project—a web-based application for discovering, installing, and publishing packages. Using ArtifactHub will help new users find this Helm chart and provide greater visibility for the project.

  1. Create an account at ArtifactHub).
  2. Register this repository.
  3. Create an artifacthub-repo.yml file in this PR inside the chart folder:
    repositoryID: <REPOSITORY ID>
    owners:
      - name: <Your Name>
        email: <Your Email>

Documentation: ArtifactHub Verified Publisher Guide

Issues Fixed or Closed

Signed-off-by: Ludovic Ortega <[email protected]>
Signed-off-by: Ludovic Ortega <[email protected]>
Signed-off-by: Ludovic Ortega <[email protected]>
@M0NsTeRRR M0NsTeRRR marked this pull request as draft December 8, 2024 14:52
@M0NsTeRRR M0NsTeRRR force-pushed the develop branch 4 times, most recently from b004da7 to 56b5c67 Compare December 19, 2024 23:16
@M0NsTeRRR M0NsTeRRR marked this pull request as ready for review December 19, 2024 23:20
@gauthier-th
Copy link
Collaborator

@djjudas21 could you please review this too?

@djjudas21
Copy link

It's not letting me give an actual review as I don't have write access on the repo, but I've been through the commits and it looks good to me 👌

fallenbagel
fallenbagel previously approved these changes Jan 11, 2025
Copy link
Owner

@fallenbagel fallenbagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
@gauthier-th any comments?

Copy link
Collaborator

@gauthier-th gauthier-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Looks like there is an issue with the codeowners file

@M0NsTeRRR
Copy link
Contributor Author

M0NsTeRRR commented Jan 12, 2025

image Looks like there is an issue with the codeowners file

Unfortunately, GitHub only allows CODEOWNERS with write access to the repository.
github/docs#18984

Copy link
Collaborator

@gauthier-th gauthier-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
For the codeowners thing, we'll ping you to ask you to review any changes related to the Helm chart.

@fallenbagel fallenbagel merged commit 3cc34b0 into fallenbagel:develop Jan 12, 2025
9 checks passed
@fallenbagel
Copy link
Owner

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Official helm chart
4 participants