feat: allow request managers to delete data from sonarr/radarr

[xabufr]

Description

Allow users who have the MANAGE_REQUESTS right to delete media files.
I've done that on the request list to have a quick access to this feature.

This doesn't need to change the API because the API already only requires MANAGE_REQUESTS for this call.

Screenshot (if UI-related)

To-Dos

• Successful build yarn build
• Translation keys yarn i18n:extract
• Database migration (if required)

Issues Fixed or Closed

Related to:

• Let normal users request the deletion of media #393

[Panda260]

oh very cool. very nice idea

[Panda260]

@xabufr who can request a deleting?
Only that person who also requested that same movie/tv show?

[xabufr]

Any person with the MANAGE_REQUESTS can delete any movie/tv show.

[Panda260]

Any person with the MANAGE_REQUESTS can delete any movie/tv show.

So now a user who has permission could simply delete the requested film from every other user? when he has the rights for that?

[Panda260]

Wouldn't it be better if everyone could delete their own requested movie or TV shows just as a suggestion

[xabufr]

Any person with the MANAGE_REQUESTS can delete any movie/tv show.

So now a user who has permission could simply delete the requested film from every other user? when he has the rights for that?

Yes, any user that can 'manage requests' can delete any request. That was already the case, this PR just add a button to allow the user to also delete request's data, but it don't modify necessary rights.

Wouldn't it be better if everyone could delete their own requested movie or TV shows just as a suggestion

There is currently no permission to delete you own requests I think (and no button for that), this would require more work, I did this PR as a quick/easy new feature.

[Gauvino]

Tested and works like a charm, just remove the renaming change on en.json (overseerr to jellyseerr) and the change on fr.json causing weblate trouble please

[xabufr]

@Gauvino I removed the bad commit for the en.json file, but for the new translation keys where should I put them?

[Gauvino]

@Gauvino I removed the bad commit for the en.json file, but for the new translation keys where should I put them?

You just keep the translation keys on the en.json, remove the change in fr.json

[xabufr]

done !

[xabufr]

@fallenbagel is it good for you?

[github-actions]

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

[Gauvino]

Could you refactor this to make it work with the new fetch api please ?

[gauthier-th]

Please update your PR to use the Fetch API instead of Axios.

[Gauvino]

@xabufr don't know if you missed, but please could you update and use the fetch API? Thanks!

[xabufr]

Yes sorry I completely forget this issue, I'll try to do it this week

[github-actions]

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

[xabufr]

@Gauvino & @gauthier-th I've made requested changes about fetch API

[Gauvino]

Tested and works as expected with movies and series!

[fallenbagel]

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

• v2.0.0
• GitHub release

Your semantic-release bot 📦🚀

[holzerseb]

Not sure if this is the desired behaviour or a bug - but this new feature to remove media from sonarr/radarr is only available through the request page. When one navigates to the media page itself and clicks on "Manage Movie" the window shows only the option to delete the request, and afterwards is completely empty:

Only users with the "Admin" permission can see the option to remove the media:

Is this the desired effect or am I missing something @gauthier-th ? Thank you so much for the project!

[gauthier-th]

Not sure if this is the desired behaviour or a bug - but this new feature to remove media from sonarr/radarr is only available through the request page.

This is the desired behavior.

Only users with the "Admin" permission can see the option to remove the media:

I can't reproduce this issue. Is there anything specific you did to have this issue?
Here is the view of a user with the Manage Request permission on the latest version:

In any case, I don't think it has anything to do with this issue. This issue only adds the "Delete from *arr" button in the request list.