fix: use UTF8 encoding for webhook JSON #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now, this might (will?) possibly break existing webhooks, but I'm not 100% sure since ASCII should just be a subset of UTF8. Will need to be tested but since I'm on a new instance I can't. |
|
LGTM! |
fallenbagel
approved these changes
Apr 13, 2024
fallenbagel
requested changes
Apr 19, 2024
joshuaboniface
force-pushed
the
fix-webhook-utf8
branch
from
af01f21 to
e5e6c4f
Compare
joshuaboniface
changed the title
fallenbagel
approved these changes
Apr 29, 2024
|
@all-contributors please add @joshuaboniface for code |
|
I've put up a pull request to add @joshuaboniface! 🎉 |
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch to using UTF8 encoding instead of ASCII for Webhook bodies. With ASCII, extended characters like emojis will throw errors here, but UTF8 allows encoding anything in the JSON payload.
Screenshot (if UI-related)
To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed