Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Older state events overwrite newer ones on fetching history #2023

Merged
merged 1 commit into from
Feb 12, 2025
Merged

fix: Older state events overwrite newer ones on fetching history #2023

merged 1 commit into from
Feb 12, 2025

Conversation

krille-chan
Copy link
Contributor

closes #1772

@krille-chan krille-chan mentioned this pull request Feb 7, 2025
Closed
2 tasks
@PhantomRay
Copy link
Contributor

I will test it now.

PhantomRay
PhantomRay reviewed Feb 9, 2025
View reviewed changes
lib/src/client.dart Outdated Show resolved Hide resolved
@krille-chan krille-chan force-pushed the krille/make-sure-we-do-not-override-state-on-fetch-history branch from 1a37f52 to 700b36f Compare February 10, 2025 07:36
@PhantomRay
Copy link
Contributor

Testing it now.

@PhantomRay
Copy link
Contributor

Thanks for fixing this. I confirm that the followings are working as expected:

  • user name/avatar for direct chat
  • name/avatar for non-direct chat
  • custom room state is not overwritten by older ones, and can be updated by newer ones

@PhantomRay
Copy link
Contributor

Gentlemen, any plan to merge this?

@td-famedly
Copy link
Member

nitpick but would it be possible to add a test for this as well? Given that we have proper reproducible steps now?

@krille-chan krille-chan marked this pull request as ready for review February 11, 2025 14:57
@krille-chan krille-chan requested a review from a team as a code owner February 11, 2025 14:57
@krille-chan krille-chan force-pushed the krille/make-sure-we-do-not-override-state-on-fetch-history branch from 700b36f to fdbe95b Compare February 11, 2025 14:57
td-famedly
td-famedly approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@td-famedly td-famedly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@krille-chan krille-chan merged commit 352b3fa into main Feb 12, 2025
14 of 15 checks passed
@krille-chan krille-chan deleted the krille/make-sure-we-do-not-override-state-on-fetch-history branch February 12, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhantomRay PhantomRay PhantomRay left review comments

@td-famedly td-famedly td-famedly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Room name/avatar replaced with older value after historical events emitted
3 participants
@krille-chan @PhantomRay @td-famedly