Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add is_requester_admin parameter to upgrade room callback #21

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

nico-famedly
Copy link
Member

This is for consistency with the room create API.

This is for consistency with the room create API.
@nico-famedly nico-famedly requested a review from a team as a code owner February 24, 2025 17:29
@jason-famedly
Copy link

Ignoring Complement and Sytest flakes, I'm happy if CI passes

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.66%. Comparing base (faa7659) to head (420d831).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
synapse/handlers/room.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   78.66%   78.66%   -0.01%     
==========================================
  Files         472      472              
  Lines       67488    67491       +3     
  Branches    10367    10368       +1     
==========================================
+ Hits        53091    53092       +1     
- Misses      10893    10894       +1     
- Partials     3504     3505       +1     
Files with missing lines Coverage Δ
...api/callbacks/third_party_event_rules_callbacks.py 67.68% <100.00%> (ø)
synapse/handlers/room.py 74.38% <50.00%> (-0.21%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faa7659...420d831. Read the comment docs.

@jason-famedly jason-famedly merged commit 4a18248 into master Feb 24, 2025
52 of 53 checks passed
nico-famedly added a commit that referenced this pull request Feb 26, 2025
This is for consistency with the room create API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants