-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lots of bug fixes and program improvements #50
base: master
Are you sure you want to change the base?
Conversation
Hi @soulteary, Thanks for looking into this. Unfortunately I am very busy and didn't find time to handle those PRs. If possible, I would prefer to merge the original author's PRs to give them the credit. But I understand they were created long time ago, may not be mergeable now. I tried to merge the first two and others are all having conflicts. Do you mind help me ask the original PR authors by leaving a comment there. If they didn't respond in a week then I will review and merge your PR if it looks good to me. |
Thank you for your reply @fangpenlin . If you merge, I suggest reset my last two commits. These two commits are used to serve other projects that rely on avataaars before the PR merge.
|
This software was not created by me, so I published this software package to
|
I understand, but I thought maybe your version bump could be an invalid semver. |
Yes, this version is only a temporary version to avoid collisions with the original repo. You can read the |
This project has some historical PRs that cannot be merged because of file conflicts, so I updated the code and resolved the conflict. Below is the merged code (Thank these authors for their hard work).
In addition, I upgraded the dependencies to the latest, which resolved the security issues that prompted when installing the dependencies.
And it solves a warning generated when the no-op function is executed when the server is rendering. Currently, the newer v16 version and the latest version of react are supported.
I wonder if the maintainer can merge these changes and release a new version?
Before the author merges the code, if you have a need for the above functions, you can install a temporary replacement package: