Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Conversation CSV loader #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

arun-esh
Copy link
Member

This PR involves the fix for the CSV loader.

Class Conversation(id) requires the id to find the details of the conversations which has :

  • participants
  • size of the conversation (or length of messages)
  • list of messages

This PR involves the fix for the CSV loader.

`Class Conversation(id)` requires the `id` to find the details of the
conversations which has :
- participants
- size of the conversation (or length of messages)
- list of messages
@arun-esh
Copy link
Member Author

@hosseinfani Please review this PR. Thanks

src/cmn/conversation.py Show resolved Hide resolved
src/cmn/conversation.py Show resolved Hide resolved
src/cmn/conversation.py Show resolved Hide resolved
@hosseinfani
Copy link
Member

Hi @arun-esh
thank you for the PR. please see my comments above

@arun-esh
Copy link
Member Author

Hi @hosseinfani,

Please review the PR once again.

@hamedwaezi01 hamedwaezi01 self-assigned this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants