-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added %~dp0 to installs #16
base: master
Are you sure you want to change the base?
Conversation
@shanselman you're (not yet) a contributer, please have a look at this PR if you can 😁 |
Testing... |
|
Try this instead of the DownloadFile() call. It'll give you a free progress bar.
|
Will give it a go, thank you! BTW - you're now also a contributor @shanselman :) |
Also, I hear you about the tools and jq and all that, but I'm also wondering if:
I need to run, but I'll look more later? |
That's great, thanks for your feedback @shanselman! My initial aim was to use almost no PowerShell, but I suppose it's an obvious choice. PS is just awesome. Maybe the whole thing should be PS scripts... |
Good question. Perhaps, but your cmd approach allows us to use cmd.exe (which I use a lot) so perhaps we do a hybrid to start? You've made it modular in that it needs to "get a json, extract latest version, put it in a file" and that means we can just remove the need for the \tools folder by using one line PowerShell commands as functions. Just like I replaced DownloadFile with a nicer one, but it still fits into the larger batch. |
If you use PS, you could place it on Powershell Gallery or Chocolatey, and make it more installer friendly (instead od copying scripts around) |
Hopefully this finally fixes #12 and #15