[fix] AttributeError (Resolves #157) #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alireza2n
changed the title
|
Hmm, I could be wrong but I think the more correct fix would be to replace line 110: return self._stream_or_respond([channel], request._request)with: return self._stream_or_respond([channel], request)Maybe @enzofrnt can confirm. |
|
Hi, I have fixed it. I will make a pull request about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ASGIRequest' object has no attribute _requestis raised while usingviewsets.EventsViewSet. Also mentioned in #157Solution
A simple attribute check on
django_eventstream/viewsets.py:118Credits
User tomiduss for providing the fix in issue #157 and to all other contributors especially @jkarneges 👍