Don't clone Scope::get

faradayio · Oct 26, 2023 · 527c26a · 527c26a
1 parent 7dbfef9
commit 527c26a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/infer.rs b/src/infer.rs
@@ -302,7 +302,9 @@ mod tests {
     }
 
     fn lookup(scope: &ScopeHandle, name: &str) -> Option<Type<TypeVar>> {
-        scope.get(&CaseInsensitiveIdent::new(name, Span::Unknown))
+        scope
+            .get(&CaseInsensitiveIdent::new(name, Span::Unknown))
+            .cloned()
     }
 
     macro_rules! assert_defines {

diff --git a/src/scope.rs b/src/scope.rs
@@ -179,9 +179,9 @@ impl Scope {
     }
 
     /// Get a value from the scope.
-    pub fn get(&self, name: &CaseInsensitiveIdent) -> Option<ScopeValue> {
+    pub fn get<'scope>(&'scope self, name: &CaseInsensitiveIdent) -> Option<&'scope ScopeValue> {
         match self.names.get(name) {
-            Some(ScopeEntry::Defined(value)) => Some(value.to_owned()),
+            Some(ScopeEntry::Defined(value)) => Some(value),
             Some(ScopeEntry::Hidden) => None,
             None => {
                 if let Some(parent) = self.parent.as_ref() {