Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: coverage fixups #287

Merged
merged 1 commit into from
Jul 26, 2023
Merged

chore: coverage fixups #287

merged 1 commit into from
Jul 26, 2023

Conversation

horsefacts
Copy link
Collaborator

@horsefacts horsefacts commented Jul 26, 2023

Motivation

Recent coverage reports show a couple uncovered lines in StorageRent and FnameResolver.

Change Summary

Add a test for the selector check in FnameResolver and the initial price update in StorageRent.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

Focus of the PR:

This PR focuses on adding a new test function testFuzzResolveRevertsNonAddrFunction and updating an existing test function testInitialPriceUpdate.

Detailed summary:

  • Added a new test function testFuzzResolveRevertsNonAddrFunction in the FnameResolver contract.
  • Updated the testInitialPriceUpdate function in the StorageRent contract.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@horsefacts horsefacts added the chore A task that is none of the other types label Jul 26, 2023
@github-actions
Copy link

Coverage after merging horsefacts/coverage-fixups into main will be

98.62%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Bundler.sol100%100%100%100%
   FnameResolver.sol100%100%100%100%
   IdRegistry.sol100%100%100%100%
   KeyRegistry.sol100%100%100%100%
   StorageRent.sol100%100%100%100%
src/lib
   TransferHelper.sol0%0%0%0%15, 15, 15, 25–26, 26, 26

@horsefacts horsefacts merged commit df0a765 into main Jul 26, 2023
2 checks passed
@horsefacts horsefacts deleted the horsefacts/coverage-fixups branch July 26, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A task that is none of the other types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants