feat(KeyRegistry): add settable IdRegistry #290
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
KeyRegistry
contractowner
should be able to update theIdRegistry
address, in case of a future upgrade.Change Summary
Use a minimal interface for
IdRegistry
inKeyRegistry
. Add an authenticated setter function.Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewAdditional Context
Close #264
PR-Codex overview
Detailed summary
BundleRegistryGasUsageTest
contract has increased.IdRegistryGasUsageTest
contract remains the same.SetIdRegistry
has been added to theKeyRegistry
contract.testFuzzOnlyAdminCanSetIdRegistry
andtestFuzzSetIdRegistry
have been added to theKeyRegistryTest
contract.KeyRegistry
contract now uses theIdRegistryLike
interface instead of theIdRegistry
contract.