Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(KeyRegistry): add settable IdRegistry #290

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

horsefacts
Copy link
Collaborator

@horsefacts horsefacts commented Jul 28, 2023

Motivation

The KeyRegistry contract owner should be able to update the IdRegistry address, in case of a future upgrade.

Change Summary

Use a minimal interface for IdRegistry in KeyRegistry. Add an authenticated setter function.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

Close #264


PR-Codex overview

Detailed summary

  • The gas usage for two functions in the BundleRegistryGasUsageTest contract has increased.
  • The gas usage for two functions in the IdRegistryGasUsageTest contract remains the same.
  • An event SetIdRegistry has been added to the KeyRegistry contract.
  • Two new functions testFuzzOnlyAdminCanSetIdRegistry and testFuzzSetIdRegistry have been added to the KeyRegistryTest contract.
  • The KeyRegistry contract now uses the IdRegistryLike interface instead of the IdRegistry contract.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@github-actions
Copy link

Coverage after merging horsefacts/update-id-registry-in-key-registry into main will be

98.70%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Bundler.sol100%100%100%100%
   FnameResolver.sol100%100%100%100%
   IdRegistry.sol100%100%100%100%
   KeyRegistry.sol100%100%100%100%
   StorageRent.sol100%100%100%100%
src/lib
   Signatures.sol100%100%100%100%
   TransferHelper.sol0%0%0%0%15, 15, 15, 25–26, 26, 26
   TrustedCaller.sol100%100%100%100%

@horsefacts horsefacts marked this pull request as ready for review July 28, 2023 23:30
@horsefacts horsefacts added the feat New feature request label Jul 28, 2023
@varunsrin varunsrin merged commit 5d62f7a into main Jul 30, 2023
2 checks passed
@varunsrin varunsrin deleted the horsefacts/update-id-registry-in-key-registry branch July 30, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: owner should be able to update IdRegistry address in KeyRegistry
2 participants