Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove deprecation warning from docker-compose.yml #417

Merged
merged 1 commit into from
May 21, 2024

Conversation

sds
Copy link
Member

@sds sds commented May 21, 2024

Motivation

Newer versions of Docker Compose warn about the version property now being deprecated.

Change Summary

Remove it so the bots are happy.

Merge Checklist


PR-Codex overview

This PR updates the docker-compose.yml file to set a specific Dockerfile for the build process.

Detailed summary

  • Updated the Dockerfile used for building to Dockerfile.foundry

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@sds sds changed the title Fix deprecation warning by removing version from docker-compose.yml fix: Remove deprecation warning from docker-compose.yml May 21, 2024
@sds sds added the chore A task that is none of the other types label May 21, 2024
@sds sds merged commit dec97bd into main May 21, 2024
1 of 4 checks passed
@sds sds deleted the sds/fix-deprecation branch May 21, 2024 06:20
@sds
Copy link
Member Author

sds commented May 21, 2024

Merging since failures are unrelated to this change, and we just want to fix this for local dev when working with other repos.

Copy link

Coverage after merging sds/fix-deprecation into main will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Bundler.sol100%100%100%100%
   FnameResolver.sol100%100%100%100%
   IdGateway.sol100%100%100%100%
   IdRegistry.sol100%100%100%100%
   KeyGateway.sol100%100%100%100%
   KeyRegistry.sol98.61%94.44%100%100%153, 153
   RecoveryProxy.sol100%100%100%100%
   StorageRegistry.sol100%100%100%100%
src/abstract
   EIP712.sol100%100%100%100%
   Guardians.sol100%100%100%100%
   Migration.sol96.97%90%100%100%40
   Nonces.sol100%100%100%100%
   Signatures.sol100%100%100%100%
src/validators
   SignedKeyRequestValidator.sol100%100%100%100%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A task that is none of the other types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant