Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(hubble): update allow-list instructions #1234

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

varunsrin
Copy link
Member

@varunsrin varunsrin commented Aug 8, 2023

Motivation

Update the instructions to follow the new allowlist process.

Change Summary

See above.

Merge Checklist


PR-Codex overview

Detailed summary:

This PR focuses on updating the location to add the PeerId to the allowed peers list. It also updates the location for the allowed peers list.

Notable changes:

  • The PeerId is now added to the allowed peers list in a different location.
  • The location for the allowed peers list is updated to a different repository.
  • After the merge, other Hubs will start peering with you after 1 hour.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2023

⚠️ No Changeset found

Latest commit: 51f6b4c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview Aug 8, 2023 4:12am

@varunsrin varunsrin added the t-docs Add or update documentation label Aug 8, 2023
@varunsrin varunsrin self-assigned this Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (83e3c61) 69.94% compared to head (51f6b4c) 69.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1234      +/-   ##
==========================================
+ Coverage   69.94%   69.95%   +0.01%     
==========================================
  Files          85       85              
  Lines        7675     7675              
  Branches     1672     1672              
==========================================
+ Hits         5368     5369       +1     
+ Misses       2155     2154       -1     
  Partials      152      152              

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@varunsrin varunsrin merged commit a855960 into main Aug 8, 2023
8 checks passed
@varunsrin varunsrin deleted the varunsrin/update-allowlist-instructions branch August 8, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-docs Add or update documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants