Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow residual message limits for fids without any storage #1626

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sanjayprabhu
Copy link
Contributor

@sanjayprabhu sanjayprabhu commented Jan 18, 2024

Motivation

Implements farcasterxyz/protocol#139

Adds a small amount of residual storage for fids that have 0 units for storage. This allows hubs to continue to store small amounts of data for any fid.

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

This PR focuses on allowing residual message limits for fids without any storage.

Detailed summary

  • Added a new feature to allow residual message limits for fids without any storage.
  • Modified several files to implement this feature.
  • Updated test cases to reflect the changes.

The following files were skipped due to too many changes: apps/hubble/src/rpc/test/server.test.ts, apps/hubble/src/storage/stores/store.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@sanjayprabhu sanjayprabhu added the t-feat Add a new feature or protocol improvement label Jan 18, 2024
Copy link

changeset-bot bot commented Jan 18, 2024

🦋 Changeset detected

Latest commit: 3c2309f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@farcaster/core Patch
@farcaster/hubble Patch
@farcaster/hub-nodejs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2024 5:37am

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2c212a2) 0.00% compared to head (3c2309f) 73.84%.

Files Patch % Lines
apps/hubble/src/storage/stores/store.ts 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main    #1626       +/-   ##
=========================================
+ Coverage      0   73.84%   +73.84%     
=========================================
  Files         0       99       +99     
  Lines         0     8919     +8919     
  Branches      0     1980     +1980     
=========================================
+ Hits          0     6586     +6586     
- Misses        0     2215     +2215     
- Partials      0      118      +118     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrei0x309
Copy link

Is this still considered?

It's an important change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-feat Add a new feature or protocol improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants