Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune messages after merge #1989

Closed
wants to merge 2 commits into from

Commits on May 13, 2024

  1. Prune message after merge

    Updates isPrunable to be getPruneAction which lets caller know if
    message should be pruned (original function) or would cause a prune
    action (added functionality). When applicable we prune for the given
    FID after the message is merged.
    
    Prune job is still running in the background but can be removed
    in the future once it's confirmed there's no stragglers.
    
    Benchmarking with production data, this change seems to add a 5%
    overhead on average. The FID lock added to Store::prune_messages
    is required for performance reasons. Without the lock, the overhead
    is run dependent and takes 100%-500% longer.
    loriopatrick committed May 13, 2024
    Configuration menu
    Copy the full SHA
    4c7f1dc View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Configuration menu
    Copy the full SHA
    f5d1705 View commit details
    Browse the repository at this point in the history