Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to migrate RocksDB database #2009

Closed

Conversation

loriopatrick
Copy link

@loriopatrick loriopatrick commented May 17, 2024

Motivation

Allows you to tweak storage settings for testing / benchmarking.

Change Summary

Makes addon modules public. Doesn't affect runtime application, only adds helpful script to migrate the database state for testing.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

The focus of this PR is to refactor the lib.rs file, add a new binary migrate-db, and improve the database migration process.

Detailed summary

  • Moved modules to pub mod in lib.rs
  • Added a new binary migrate-db in Cargo.toml
  • Refactored database open method in rocksdb.rs
  • Implemented a database migration script in migrate_db.rs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented May 17, 2024

⚠️ No Changeset found

Latest commit: ff7970c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 4:20pm

Allows you to tweak storage settings for testing / benchmarking.
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.20%. Comparing base (1880070) to head (ff7970c).
Report is 381 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (1880070) and HEAD (ff7970c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1880070) HEAD (ff7970c)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2009       +/-   ##
===========================================
- Coverage   74.05%   36.20%   -37.86%     
===========================================
  Files          99      140       +41     
  Lines        9425    21996    +12571     
  Branches     2097     7512     +5415     
===========================================
+ Hits         6980     7963      +983     
- Misses       2327    12491    +10164     
- Partials      118     1542     +1424     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sds
Copy link
Member

sds commented Oct 1, 2024

Closing due to age. Thanks for your work on this!

@sds sds closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants