Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lastSyncTimestamp to GetInfo rpc endpoint #2071

Closed

Conversation

aditiharini
Copy link
Contributor

@aditiharini aditiharini commented Jun 19, 2024

Motivation

Provide more visibility into hub sync state.

Change Summary

Add lastSyncTimestamp to the GetInfo rpc endpoint.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR introduces a new lastSyncTimestamp field to the HubInfoResponse message in various files for tracking the time of the last successful sync operation.

Detailed summary

  • Added lastSyncTimestamp field to HubInfoResponse message
  • Updated message.ts, server.ts, test files, and generated files
  • Implemented getLastSyncTimestamp method in SyncEngine class

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Jun 19, 2024

🦋 Changeset detected

Latest commit: f4fd19d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@farcaster/hub-nodejs Minor
@farcaster/hub-web Minor
@farcaster/hubble Minor
@farcaster/shuttle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ❌ Failed (Inspect) Jun 19, 2024 2:32am

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 45.23%. Comparing base (1880070) to head (f4fd19d).
Report is 197 commits behind head on main.

Files Patch % Lines
...kages/hub-nodejs/src/generated/request_response.ts 0.00% 6 Missing and 4 partials ⚠️
...s/core/src/protobufs/generated/request_response.ts 50.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2071       +/-   ##
===========================================
- Coverage   74.05%   45.23%   -28.82%     
===========================================
  Files          99      140       +41     
  Lines        9425    22478    +13053     
  Branches     2097     7871     +5774     
===========================================
+ Hits         6980    10169     +3189     
- Misses       2327    10694     +8367     
- Partials      118     1615     +1497     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aditiharini aditiharini marked this pull request as ready for review June 19, 2024 03:08
@Wazzymandias
Copy link
Contributor

At some point we should also update the peers gRPC endpoint to return the peer id per peer. Not related to this PR, just musing

@sds
Copy link
Member

sds commented Oct 1, 2024

Closing due to age. If this is still relevant let's reopen and rebase. Thanks!

@sds sds closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants