-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: increase max stream reader shards #2301
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: b28284a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2301 +/- ##
===========================================
- Coverage 74.05% 44.33% -29.72%
===========================================
Files 99 146 +47
Lines 9425 25476 +16051
Branches 2097 9227 +7130
===========================================
+ Hits 6980 11296 +4316
- Misses 2327 12430 +10103
- Partials 118 1750 +1632 ☔ View full report in Codecov by Sentry. |
Closing as we went a different direction. |
The backend is experiencing inbound message processing delays. In order to increase sharding and see if it helps resolve the issue, we need to bump this parameter on the hub side.
Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewPR-Codex overview
This PR increases the
MAX_EVENT_STREAM_SHARDS
from 10 to 20 in the@farcaster/hubble
package and updates related constants inapps/hubble/src/rpc/server.ts
.Detailed summary
MAX_EVENT_STREAM_SHARDS
from 10 to 20DEFAULT_SUBSCRIBE_PERIP_LIMIT
andDEFAULT_SUBSCRIBE_GLOBAL_LIMIT
constants