Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase max stream reader shards #2301

Closed

Conversation

aditiharini
Copy link
Contributor

@aditiharini aditiharini commented Sep 10, 2024

The backend is experiencing inbound message processing delays. In order to increase sharding and see if it helps resolve the issue, we need to bump this parameter on the hub side.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR increases the MAX_EVENT_STREAM_SHARDS from 10 to 20 in the @farcaster/hubble package and updates related constants in apps/hubble/src/rpc/server.ts.

Detailed summary

  • Bumps MAX_EVENT_STREAM_SHARDS from 10 to 20
  • Updates DEFAULT_SUBSCRIBE_PERIP_LIMIT and DEFAULT_SUBSCRIBE_GLOBAL_LIMIT constants

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 3:25pm

Copy link

changeset-bot bot commented Sep 10, 2024

🦋 Changeset detected

Latest commit: b28284a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aditiharini aditiharini changed the title feat: increase max stream reader shards chore: increase max stream reader shards Sep 10, 2024
@aditiharini aditiharini added the t-chore Miscellaneous improvements label Sep 10, 2024
@aditiharini aditiharini marked this pull request as ready for review September 10, 2024 14:31
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.33%. Comparing base (1880070) to head (b28284a).
Report is 373 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2301       +/-   ##
===========================================
- Coverage   74.05%   44.33%   -29.72%     
===========================================
  Files          99      146       +47     
  Lines        9425    25476    +16051     
  Branches     2097     9227     +7130     
===========================================
+ Hits         6980    11296     +4316     
- Misses       2327    12430    +10103     
- Partials      118     1750     +1632     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sds
Copy link
Member

sds commented Sep 26, 2024

Closing as we went a different direction.

@sds sds closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-chore Miscellaneous improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants