Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect method call in the test #2498

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Fix incorrect method call in the test #2498

merged 1 commit into from
Jan 27, 2025

Conversation

intls
Copy link
Contributor

@intls intls commented Jan 26, 2025

Why is this change needed?

In the test block "validateMessage", the test "fails without signer" incorrectly calls the method submitMessage instead of validateMessage.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR updates the test cases in the messageService.test.ts file to replace calls to client.submitMessage with client.validateMessage, ensuring that the validation logic is tested instead of the submission logic.

Detailed summary

  • Changed client.submitMessage(castAdd) to client.validateMessage(castAdd).
  • Changed client.submitMessage(frameAction) to client.validateMessage(frameAction).
  • Updated the error handling expectations to reflect changes in the message validation process.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Jan 26, 2025

⚠️ No Changeset found

Latest commit: 3224412

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2025 3:02am

@sds sds merged commit bae108d into farcasterxyz:main Jan 27, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants