Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HapCUT2 update #11

Merged
merged 1 commit into from
Feb 4, 2021
Merged

HapCUT2 update #11

merged 1 commit into from
Feb 4, 2021

Conversation

olavurmortensen
Copy link
Collaborator

HapCUT2 v1.2 had a sporadic error, discussed here:

vibansal/HapCUT2#77

This was fixed in v1.3.

Updated HapCUT2 from v1.2 to v1.3, and to avoid package conflicts also updated samtools from v1.9 to v1.10.

No changes were made in HapCUT2 from v1.2 to v1.3 that have any significant effect on LinkSeq (https://github.com/vibansal/HapCUT2/releases).

In samtools from v1.9 to v1.10 there was one change that has some change to LinkSeq (see: https://github.com/samtools/samtools/releases/tag/1.10):

samtools sub-commands will now add @pg header lines to output sam/bam/cram files. To disable this, use the --no-PG option. (#1087; #1097)

The BAM files produced in LinkSeq already had @PG headers, so this should not have an effect on LinkSeq.

@olavurmortensen
Copy link
Collaborator Author

Test run on tiny-bcl successful.

@olavurmortensen olavurmortensen merged commit 530b141 into master Feb 4, 2021
@olavurmortensen olavurmortensen deleted the hapcut2_fix branch February 4, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant