Skip to content

Commit

Permalink
chore: add changeset check (#1066)
Browse files Browse the repository at this point in the history
* chore: add changeset check

* chore: update changesets and lockfile

* fix: ci changeset check

* chore: changeset diff origin/main

* chore: fetch-depth 0

---------

Co-authored-by: brightwwu <[email protected]>
  • Loading branch information
wre232114 and brightwwu authored Mar 25, 2024
1 parent dab85fc commit 5b793e9
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 9 deletions.
2 changes: 2 additions & 0 deletions .changeset/tiny-berries-compare.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
4 changes: 4 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: 18
Expand All @@ -84,6 +86,8 @@ jobs:
run: pnpm --filter @farmfe/cli run build
- name: Type Check With Tsc
run: pnpm run --filter "@farmfe/*" type-check
- name: Changesets Check
run: npx changeset status --since=origin/main

ts-test:
name: Typescript Test
Expand Down
Binary file modified assets/benchmark-full.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 4 additions & 4 deletions packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,9 @@
"type-check": "tsc -p tsconfig.build.json"
},
"dependencies": {
"@farmfe/runtime": "workspace:^0.10.0",
"@farmfe/runtime-plugin-hmr": "workspace:^3.5.1",
"@farmfe/runtime-plugin-import-meta": "workspace:*",
"@farmfe/runtime": "workspace:0.10.0",
"@farmfe/runtime-plugin-hmr": "workspace:3.5.1",
"@farmfe/runtime-plugin-import-meta": "workspace:0.2.0",
"@farmfe/utils": "workspace:*",
"@koa/cors": "^4.0.0",
"@swc/helpers": "^0.5.0",
Expand All @@ -121,4 +121,4 @@
"zod": "^3.21.4",
"zod-validation-error": "^1.3.0"
}
}
}
2 changes: 0 additions & 2 deletions packages/core/src/config/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -384,8 +384,6 @@ export async function normalizeUserCompilationConfig(
config.define.FARM_HMR_PROTOCOL = userConfig.server.hmr.protocol;

const defineHmrPath = normalizeBasePath(path.join(publicPath, hmrPath));
// for backward compatibility
config.define.FARM_HMR_BASE = defineHmrPath;
config.define.FARM_HMR_PATH = defineHmrPath;
}

Expand Down
6 changes: 3 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 5b793e9

Please sign in to comment.