Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add freeze_module hooks #2092

Open
wants to merge 13 commits into
base: v2-dev
Choose a base branch
from
Open

feat: add freeze_module hooks #2092

wants to merge 13 commits into from

Conversation

ErKeLost
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b070d85

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package or glob expression "farm-docs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@ErKeLost ErKeLost added the WIP Working in progress label Feb 13, 2025
@ErKeLost ErKeLost marked this pull request as draft February 13, 2025 07:30
@ErKeLost ErKeLost marked this pull request as ready for review February 18, 2025 07:17
wre232114
wre232114 reviewed Feb 19, 2025
View reviewed changes
crates/node/src/plugin_adapters/js_plugin_adapter/hooks/freeze_module.rs
content: String,
}

fn format_module_metadata_to_code(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can extract this method as a util which can be shared between different hook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wre232114 wre232114 wre232114 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
WIP Working in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ErKeLost @wre232114