Minor fixes (#88)

Co-authored-by: Chris Wu <[email protected]>
faros-ai · Nov 30, 2023 · 9f15c82 · 9f15c82
1 parent 6b44e2d
commit 9f15c82
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/airbyte-local.sh b/airbyte-local.sh
@@ -321,7 +321,7 @@ function copyFarosConfig() {
     if [[ $src_docker_image == farosai/airbyte-faros-feeds-source* && $dst_docker_image == farosai/airbyte-faros-destination* ]]; then
             # Extract Faros API config from destination config
             faros_config=$(jq '{faros: {api_url: .edition_configs.api_url, api_key: .edition_configs.api_key, graph: .edition_configs.graph, graphql_api: .edition_configs.graphql_api} | with_entries(if .value==null then empty else . end)}' "$tempdir/$dst_config_filename")
-            debug "Updating source config with Faros API config from destination config: $(echo "$faros_config" | jq '.faros.api_key = "REDACTED"')"
+            debug "Updating source config with Faros API settings from destination config: $(echo "$faros_config" | jq -c '.faros.api_key = "REDACTED"')"
             # Merge Faros API config into source config
             jq --argjson faros_config "$faros_config" '$faros_config + .' "$tempdir/$src_config_filename" > "$tempdir/$src_config_filename.tmp"
             mv "$tempdir/$src_config_filename.tmp" "$tempdir/$src_config_filename"
@@ -765,7 +765,9 @@ function specDst() {
 }
 
 function sync_local() {
-    debug "Writing source output to $output_filepath"
+    if [[ "$output_filepath" != "/dev/null" ]]; then
+       debug "Writing source output to $output_filepath"
+    fi
     new_source_state_file="$tempdir/new_state.json"
     readSrc |
         tee >(jq -cR $jq_color_opt --unbuffered 'fromjson? | select(.type != "RECORD" and .type != "STATE")' |

diff --git a/test/spec/airbyte-local_spec.sh b/test/spec/airbyte-local_spec.sh
@@ -201,13 +201,6 @@ Describe 'writing source output'
                 --debug
         The output should include 'Writing source output to /tmp/out.txt'
     End
-    It 'does not write source output'
-        When run source ../airbyte-local.sh \
-                --src 'farosai/dummy-source-image' \
-                --dst 'farosai/dummy-destination-image' \
-                --debug
-        The output should include 'Writing source output to /dev/null'
-    End
 End
 
 Describe 'building source catalog'