Fix arm64 devcontainer build by updating container base image, install useful vscode extensions by default #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tried to run this devcontainer on a MacBook M1 Pro, the
primplibrary failed to build because compatible wheels were not available, and the build process requires Cargo (the Rust package manager) which is not installed in the container. As seen in theprimpREADME, Linux aarch64 wheels are only compatible with Debian >=12 whereas the devcontainer base image was using Debian 11.This change upgrades the base image to use Debian 12 for compatibility with existing
primpwheels, and also upgrades to devcontainer 1.0 and Python 3.11. Also added some extensions that should be installed anyways to work with Jupyter notebooks inside the devcontainer (I think ms-toolsai.jupyter, ms-python.python and ms-azuretools.vscode-docker are required to run the notebooks, and ms-python.vscode-pylance adds code completion and other nice features).Testing these changes: Successfully built and ran the devcontainer and the first notebook on my local machine and in GH Codespaces. I can leave another comment on this PR once I run the rest of the notebooks to ensure there are no issues.