♻️ Remove modify id script in favor of openapi-ts config #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejsdev
approved these changes
Nov 25, 2024
patrick91
force-pushed
the
feature/remove-modify-id-script
branch
from
4e0ed8f to
bda9841
Compare
Interesting, I think this is just from the version upgrade. 🤔 The current/old script only renamed the path operations, not really the types. I suspect they realized that the generated types needed to be disambiguated maybe. 🤔 |
tiangolo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the modify-id script; this is now handled by a custom config for
openapi-ts.The behaviour is slightly different, as we are now only renaming the methods and not the types, which is better in cases where we have operations with the same name; see #1429's
create_userfor an example :)