Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timing middleware: add support for alternate message formatters #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Timing middleware: add support for alternate message formatters #141

wants to merge 1 commit into from

Conversation

cahna
Copy link

@cahna cahna commented Dec 9, 2020 •
edited
Loading

Hi, and thanks for the great library of utils!
I needed support for structured log messages to avoid writing custom parser logic in my app's log aggregation service (Datadog). If you are interested in including such support, this PR is how I implemented that. Backwards-compatible changes:

  • Add support for an optional message_formatter argument to add_timing_middleware()
  • Test coverage for new feature
  • Documentation for new feature
  • Fix CONTRIBUTING.md to reference make docs-live

@cahna cahna force-pushed the timing-alternate-formatter branch 3 times, most recently from a8c93b4 to 7aa3372 Compare December 9, 2020 20:16
@cahna cahna force-pushed the timing-alternate-formatter branch from 7aa3372 to 9895ae1 Compare December 9, 2020 20:20
@julyvee
Copy link

julyvee commented Dec 11, 2023 •
edited
Loading

This is exactly what I need, I hope it gets merged soon :) @dmontagu

@julyvee julyvee mentioned this pull request Dec 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cahna @julyvee