Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial devcontainer #484

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

luigi311
Copy link

Adds a devcontainer to make development work easier for new people. This will let you open up a container image based on debian that has node 20, go 1.21 and the latest stable chrome version. I tested with make test and i got the same 1 frontend error that the CI is also getting.

@CLAassistant
Copy link

CLAassistant commented Jun 20, 2024

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Luis Garcia <[email protected]>
@AnalogJ
Copy link
Member

AnalogJ commented Jun 20, 2024

hey @luigi311
Not super familiar with devcontainers, but if I'm understanding how this all works, it'll need to bind mount the config.dev.yaml file from the host machine right?

https://github.com/fastenhealth/fasten-onprem/blob/main/CONTRIBUTING.md

@luigi311
Copy link
Author

With this in the repo if you open up the repo in vscode it will prompt you if you wish to open it up in the dev container. It will then spinup a debian container and install go, node 20 and chrome along with mapping over the entire folder into the container so it will feel like you are working in a normal environment with all the deps installed. From there you can create your config.dev.yaml and do whatever work needs to be done.

I havent tested it but it should also work on a M# based mac according to the image description, if that is what you are using

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants