-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create SPA with React and Vite #81
base: main
Are you sure you want to change the base?
Conversation
59d24d4
to
d535e73
Compare
@jean-michelet SonarCloud generates errors on pieces of code that are accepted or by design correct, like for example here in the test we have an error of a nested function, it is possible to configure it so that it can give us correct feedback or it is accepted which fails permanently and that we force merge ? ![]() ![]() |
If now the tests are in If you think some files or entire folders should not be checked by sonarcloud, you should indicate them too. For false positive, I will review them directly on the dashboard of the website, and accept the changes there. |
- Update SonarCloud exclusion rules to exclude `server/test/**/*` instead of `test/**/*`
- Add `.prettierrc` file with single quote and JSX single quote setting
You could not leverage https://fastify-vite.dev/? |
@jean-michelet to guide our decisions, what is the business objective of the demo application SPA ? Architectural Evolution Separation of Concerns: Server-side Changes: Client-side Changes: Initial proposal, points to Define: Before proceeding with further implementation, this draft is open for your suggestions and comments cc: @EnzoDOROSARIO |
a7b9fb0
to
4bec8c8
Compare
|
This is relevant, if the goal is to demonstrate the use of Fastify for the generation of the SSR rendering for the client side in addition to the Fastify server If the main purpose of the demo is to present the Fastify server and the SPA exists as a pretext to consume the API, that's different. @jean-michelet this comes back to my initial question which is what is the business objective of the demo and here specifically of the SPA application? |
The aim was to introduce Fastify/vite, in particular the react part for an SPA or even an SSR (next style) if you're prepared to put in the necessary effort: https://fastify-vite.dev/react/. Bad newsThe package does not integrate typescript well and there are probably other areas to improve directly on the package. Good newsIf you really want to contribute to opensource and develop Fastify ecosystem. My advice is to read carefully the comments on this PR I started a while ago. @galvez is the main contributor @onlywei has already started some work about TypeScript integration. |
Sync @jean-michelet, I am in discussion with @galvez to certainly make an implementation with fastify/vue fastify/react not being ready for production |
Issue #20
Description: In WIP...
Checklist
npm run test
andnpm run benchmark
and the Code of conduct