Added a smoke test + updated CircleCI + updated Rubocop #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My CI/CD pipeline was sending me emails about test failures, so I updated them. To run the test, use `bundle exec rake` or `circleci local execute --job test`. The Gemfile.lock is committed to create a reproducible test environment. The .rubocop.yaml config was super outdated, so I did a quick namespace update. And I added a smoke test with a stub client. The code for passing the AWS SNS client is in another PR.
MarcPerezPro
force-pushed
the
feature/unit_testing_overhaul
branch
from
f9be7ef
to
7d063d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My CI/CD pipeline was sending me emails about test failures, so I updated them. To run the test, use
bundle exec rakeorcircleci local execute --job test.The Gemfile.lock is committed to create a reproducible test environment. The .rubocop.yaml config was super outdated, so I did a quick namespace update.
And I added a smoke test with a stub client. The code for passing the AWS SNS client is in this PR.