New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend surrogate keys instead of replacing them #719

Open

herzog31 wants to merge 3 commits into fastly:master from herzog31:extend-surrogate-keys

herzog31 commented Nov 21, 2024

Update logic in fetch to extend surrogate keys instead of replacing them if the origin returns any.
This is required for origins outside of Commerce which depend on surrogate keys for cache invalidation (e.g. Adobe Experience Manager).

I open this pull request as draft as this is untested for now.

herzog31 added 3 commits

November 20, 2024 10:56


          Append surrogate keys instead of replacing them

4199d13


          Append surrogate keys instead of replacing them

2094df6


          Merge branch 'master' into extend-surrogate-keys

5d38431

herzog31 marked this pull request as ready for review

November 21, 2024 14:32

sirugh commented Nov 21, 2024

FYI I have applied this directly to https://manage.fastly.com/configure/services/EOYnA7LoQmtBNB2xROd8C3/versions/57/snippets?customerId=3KO4CgMCsDyiIhA2EHU6Vw in the magentomodule_fetch snippet. We are validating now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet