Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defercall: use timers instead of QMetaObject::invokeMethod #48132

Merged
merged 4 commits into from
Feb 26, 2025

Conversation

jkarneges
Copy link
Member

@jkarneges jkarneges commented Feb 20, 2025

This reworks DeferCall to trigger calls using timers of zero rather than relying on a special mechanism provided by the event loop. Notably, this makes DeferCall work with the new event loop, since timers work with the new event loop.

A side effect is the timer subsystem must be initialized before queuing any deferred calls, and all deferred calls must be resolved/cleared before the timer subsystem is deinitialized.

@jkarneges jkarneges marked this pull request as draft February 21, 2025 05:54
@jkarneges jkarneges force-pushed the jkarneges/defercall-timer branch from b47ede4 to d4dc56c Compare February 24, 2025 17:29
@jkarneges jkarneges changed the title defercall: use timer instead of QMetaObject::invokeMethod defercall: use timers instead of QMetaObject::invokeMethod Feb 24, 2025
@jkarneges jkarneges force-pushed the jkarneges/defercall-timer branch from 6593e70 to d2ff573 Compare February 25, 2025 20:13
@jkarneges jkarneges marked this pull request as ready for review February 25, 2025 22:25
Copy link

@mhp mhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkarneges jkarneges merged commit 8dc9447 into main Feb 26, 2025
19 of 20 checks passed
@jkarneges jkarneges deleted the jkarneges/defercall-timer branch February 26, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants