Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handler: add option to use new event loop #48138

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Conversation

jkarneges
Copy link
Member

@jkarneges jkarneges commented Feb 27, 2025

This adds support for the new event loop in the handler, controlled by a config option (new_event_loop=true) to make it easy to test it without fully committing to it yet.

I've done some basic testing of common flows (start/stop, accept sessions, publish messages) and things look ok so far. The main thing missing is support for endpoints that use SimpleHttpServer (used by the internal control port and prometheus), as it depends on QTcpSocket which we don't have a substitute for yet. So the config options for those endpoints (push_in_http_port and prometheus_port) need to be omitted when testing, and publishing needs to go over zmq.

@jkarneges jkarneges merged commit 9263a5e into main Feb 27, 2025
19 checks passed
@jkarneges jkarneges deleted the jkarneges/handler-eventloop branch February 27, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants