Is tensor representable #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
March 22, 2024 15:23
…rn new rounding modes.
Fixed rounding_mode specifier in convert_quantized_bits
Commented out assertion on non-representability
…ay_and_auto_po2_scale Merging changes from rounding_mode_new.
…nto HEAD Merge changes from the new converter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a single function to the QKeras converter, to check if the tensor is being correctly converted. It issues only a warning to not brake legacy testing code.
This PR builds upon PR: Update qkeras converter for array and auto po2 scale #135
This is why it currently shows many differences, after they will be merged into main the only difference is in src/qonnx/converters/qkeras/onnx.py with the addition of the
check_tensor_is_representablefunction.This PR does not affect other code, nor should it be a problem for downstream users. It can be merged after PR: #135.