Add button_to execute :read task #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbuys
approved these changes
Oct 3, 2023
| def execute_read_task | ||
| system('rake read') | ||
| redirect_to root_path |
There was a problem hiding this comment.
How about using the redirect back option: https://api.rubyonrails.org/classes/ActionController/Redirecting.html#method-i-redirect_back_or_to
There was a problem hiding this comment.
I am not quite sure which controller is best for this action, but we don't have much information at this stage - so this should be fine.
| @@ -15,6 +15,10 @@ | |||
| <a class="inline-block border rounded py-1 px-3" href="/?domain=UpgradeJS.com">UpgradeJS Links</a> | |||
| </li> | |||
|
|
|||
| <li class="mr-3"> | |||
| <%= button_to "Execute 'Read' task", execute_read_task_path, class: "inline-block border rounded py-1 px-3", method: :post %> | |||
There was a problem hiding this comment.
How about we use the disable_with data option to disable the button after it is clicked?
There was a problem hiding this comment.
disable_with won't work as expected, because the redirect will reload the page.
fbuys
reviewed
Oct 3, 2023
| def execute_read_task | ||
| system('rake read') | ||
| redirect_back_or_to root_path |
There was a problem hiding this comment.
Should this be the last line of the method?
FionaDL
reviewed
Oct 4, 2023
| @@ -15,6 +15,10 @@ | |||
| <a class="inline-block border rounded py-1 px-3" href="/?domain=UpgradeJS.com">UpgradeJS Links</a> | |||
| </li> | |||
|
|
|||
| <li class="mr-3"> | |||
| <%= button_to "Run 'Sitemap' task", execute_read_task_path, class: "inline-block border rounded py-1 px-3", method: :post %> | |||
There was a problem hiding this comment.
Suggested change
| <%= button_to "Run 'Sitemap' task", execute_read_task_path, class: "inline-block border rounded py-1 px-3", method: :post %> | |
| <%= button_to "Refresh List", execute_read_task_path, class: "inline-block border rounded py-1 px-3", method: :post %> |
Using redirect_back_or_to to redirect after read task completed successfully. See: #22
fbuys
force-pushed
the
22-add-a-button-to-run-the-sitemap-reader-job
branch
from
dead939
to
6743fbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attending to issue #22, this PR aims to add a button on navigation bar to trigger :read task and sync Sitemap links.