Move bundle_report rails compatibility logic into a class #137
Conversation
|
|
||
| incompatible_gems.each { |gem| gem.find_latest_compatible(rails_version: rails_version) } |
There was a problem hiding this comment.
@arielj I noticed you wrote this code, could you please elavorate a bit on this line? why is it needed? how is used? I do not get it. Thanks!
There was a problem hiding this comment.
incompatible_gems is an array of gems that, given the current version they are in, are not compatible with the desired version of Rails
then this line loops through that array and looks for the newest version of each of those gems that is compatible with the desired version of Rails, that information is stored in the gem object itself https://github.com/fastruby/next_rails/blob/main/lib/next_rails/gem_info.rb#L137 and it's used to print the target version of that gem in line 32
There was a problem hiding this comment.
That makes sense, yeah I noticed it was related to finding the latest compatible rails version for the gem, but didn't realize it. thanks! now that I have your attention what do you think about the PR? can you review it please?
JuanVqz
force-pushed
the
move-rails-version-compatibility-into-its-own-class
branch
2 times, most recently
from
61699bf to
7f7a9df
Compare
| end | ||
|
|
||
| def incompatible_gems | ||
| @gems.reject { |gem| incompatible?(gem) }.sort_by(&:name) |
There was a problem hiding this comment.
| @gems.reject { |gem| incompatible?(gem) }.sort_by(&:name) | |
| @incompatible_gems ||= @gems.reject { |gem| incompatible?(gem) }.sort_by(&:name) |
this method is called twice in incompatible_gems_by_state, this way it won't do all the reject->sort thing twice
| @options[:rails_version] | ||
| end | ||
|
|
||
| def incompatible?(gem) |
There was a problem hiding this comment.
is this name correct? the method is called incompatible? but internally it calls gem.compatible_with_rails?... so I imagine true means compatible, not incompatible
There was a problem hiding this comment.
also, it's used in the incompatible_gems method to reject the compatible ones and keep the incompatible ones
I extracted it into a class because I think it will be easier to use the `incompatible_gems_by_state` data there.
Based on the code review
JuanVqz
force-pushed
the
move-rails-version-compatibility-into-its-own-class
branch
from
b8e927b to
74e4bf6
Compare
Description
I extracted it into its own class
Motivation and Context
I think it will be easier to understand the
BundleReport.compatibilitymethod and its usagealso I will need to use data from the
incompatible_gems_by_statemethod in another code.How Has This Been Tested?
There was an existing test case for the
erb_outputmethod, and I run it locally to make sure it still works.Screenshots:
I will abide by the code of conduct