Adds requirements specifying need for Libyaml on Linux. Closes: #121 #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #121 |
JuanVqz
reviewed
Jun 6, 2025
There was a problem hiding this comment.
@FiggyFoxFunc If you agree with the adjustment, accept the changes or create your own with the comments above then we are ready to go.
| @@ -14,6 +14,12 @@ Here's what you need to do: | |||
| - [Make sure the test suite passes on GitHub Actions and make any necessary changes to your branch to bring it to green.](#continuous-integration). | |||
| - Check out the [Help Wanted](#help-wanted) section for suggestions on how to support Skunk. | |||
|
|
|||
| ## Requirements | |||
| For Ruby ruby 3.0.2p107 on the Linux distro POP-OS install the following: | |||
There was a problem hiding this comment.
I don't mean to be a blocker, but a couple of observations:
Pop!_OSseems to be the official name- I think
Ruby ruby 3.0.2p107is kind of specific. what do you think on sayingRuby 3.0 and up?
Suggested change
| For Ruby ruby 3.0.2p107 on the Linux distro POP-OS install the following: | |
| For a Linux distro called Pop!_OS, running Ruby 3.0 and up might require installing the following packages: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added a requirements section in CONTRIBUTING.md.
I will abide by the code of conduct.