Support running inside a Web Worker #60
Conversation
…ndow nor document there), in Chrome
| @@ -12,7 +12,7 @@ | |||
| , attachEvent = 'attachEvent' | |||
| , removeEvent = 'removeEventListener' | |||
| , detachEvent = 'detachEvent' | |||
| , doc = document || {} | |||
| , doc = typeof document !== 'undefined' ? document : {} | |||
There was a problem hiding this comment.
does document || {} not do the right thing in a worker?
There was a problem hiding this comment.
no. try doing a = thisvardoesnotexist || {}; in the Chrome Javascript console :)
|
Interesting use case. I'm wondering how you're using Bean in a WebWorker? Are you listening to browser events or using it for pubsub? If the aim of this PR is to add WW support perhaps some tests for that would be neat if you can manage it. |
|
I'd like to extend this request to node.js; bean.js assumes some global objects like |
|
It makes sense to include the checks. var doc = typeof document !== 'undefined' && document |
|
I'd like to see some tests for some of this, anyone got time and ideas for testing in webworkers and/or testing in node? |
Support running from loadScript() inside a Web Worker (there is no window nor document there), in Chrome.