Fixes game resumed after a time forfeit froze

README.md

@@ -62,6 +62,7 @@ If you specify a value for the `gameCount` system property while starting the ap
 
 
 # Known bugs
+- When no time control is set, some engines never replies
 - When a game is continued after a time forfeit, its PGN still mention the initial time control.
 - When a engine that is used in player settings hangs, it leaves settings in a wrong state with no possibility to fix it; The application should be restarted.
 

src/main/java/com/fathzer/games/game/Game.java

@@ -125,6 +125,7 @@ public void run() {
 	}
 
 	private void requestMove(Color color) {
+		log.debug("Game {} request move from {} player", id, color);
 		getPlayer(color).requestMove(this, m -> this.addEvent(new MoveEvent<>(m)));
 	}
 

src/main/java/com/fathzer/games/game/GameManager.java

@@ -171,6 +171,7 @@ private void endOfGame(final Status status) {
 			// Replace game by the same one returned (for instance, the same game without clock)
 			this.game = resumed.get();
 			log.debug("Continue ended with another game at same position, state: {}", getState());
+			onNewGame(this.game);
 			setState(State.RUNNING);
 		} else {
 			log.debug("End of game,  state: {}", getState());
@@ -184,8 +185,11 @@ private void endOfGame(final Status status) {
 		}
 	}
 
+	/** Gets a new game to start just after a game just ended.
+	 * <br>A typical use of this method is to allow a game lost by time forfeit to be resumed without a clock.
+	 * @return an empty option if the game should not be resumed or the game to resume. 
+	 */
 	protected Optional<Game<M,B>> getResumedGame() {
-		//TODO comment
 		return Optional.empty();
 	}
 

src/main/java/com/fathzer/jchess/bot/EnginePlayer.java

@@ -66,7 +66,7 @@ public synchronized void requestMove(Game<Move, Board<Move>> game, Consumer<Move
 						currentSearch.set(null);
 					}
 				} catch (Exception e) {
-					log.error("An error occurred while searching for move, declare the engine dead");
+					log.error("An error occurred while searching for move, declare the engine dead", e);
 					callBack.accept(null);
 					return null;
 				}
@@ -115,10 +115,7 @@ private Optional<Move> getMove(Game<Move, Board<Move>> game) throws IOException
 			final int movesToGo = clock.getRemainingMovesBeforeNext(clock.getPlaying());
 			params = new CountDownState(remainingTime, increment, movesToGo);
 		}
-		if (params==null) {
-			System.out.println("We are fucked"); //TODO
-		}
-		if (params.getRemainingMs()<0) {
+		if (params!=null && params.getRemainingMs()<0) {
 			return Optional.empty();
 		}
 		return Optional.of(JChessUCIEngine.toMove(history.getBoard(), UCIMove.from(engine.getMove(params))));