Speed up import type (0.05 s to 0.02 s) by lazy loading requests #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmaarrfk
force-pushed
the
faster_import_time
branch
from
0faecc0
to
3bfcc68
Compare
|
@hmaarrfk sorry for the long delay on this. I've been away from OSS work for a while and am only slowly returning now. We'll get to this PR as soon as possible. Thanks for going thought the trouble and being patient 🙂 |
leouieda
reviewed
Jun 21, 2023
|
@hmaarrfk will merge this ASAP. We're having a failure on the Mac builds for Python 3.7 because the GitHub |
|
No issues. Take your time. |
|
Thanks @hmaarrfk! Finally got some time to sort this out. Thank you your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm proposing lazy loading requests since it adds a bit of import of.
Usually, I think that pooch is used as an import addon but not as a core feature. As such it is a little silly to expand the import time by alot. While small, it is not insignificant.
Thank you for considering
Current
Proposed
