Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure processor has extracted all members when members=None #365

Merged
merged 11 commits into from
Feb 19, 2024
Merged

Ensure processor has extracted all members when members=None #365

merged 11 commits into from
Feb 19, 2024

Commits on Oct 30, 2023

  1. Add failing test for fatiando#364

    @jni
    jni committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    1b56050 View commit details
    Browse the repository at this point in the history

  2. Add _all_members method for when members=None

    @jni
    jni committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    b6d53d3 View commit details
    Browse the repository at this point in the history

  3. Use local members variable instead of modifying attribute

    @jni
    jni committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    8a9e3bc View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Use existing file, since it causes same problem 

    Co-authored-by: Leonardo Uieda <[email protected]>
    @jni
    jni and Leonardo Uieda committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    f034b72 View commit details
    Browse the repository at this point in the history

  2. Format file with black

    @jni
    jni committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    89a3056 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Break line on base all_members docstring

    @leouieda
    leouieda committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    7d3db88 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Merge branch 'main' into members-no-members

    @leouieda
    leouieda committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    7b6bc47 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Merge branch 'main' into members-no-members

    @leouieda
    leouieda committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    7707d0e View commit details
    Browse the repository at this point in the history

  2. Use ABC and abstractmethod in ExtractorProcessor 

    This way we don't have to test against using it since it can't be
instantiated directly. Make _all_members and _extract_file abstract
methods.
    @leouieda
    leouieda committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    4d576d0 View commit details
    Browse the repository at this point in the history

  3. Add a check for calling with an existing member

    @leouieda
    leouieda committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    fab577f View commit details
    Browse the repository at this point in the history

  4. Make the suffix an abstract property 

    Make it required to be implemented by child classes so we don't have to
check if it's None.
    @leouieda
    leouieda committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    e59157b View commit details
    Browse the repository at this point in the history